Skip to content

[Filebeat][udp] - Remove unnecessary multiplication#41211

Merged
rdner merged 8 commits intoelastic:mainfrom
vinit-chauhan:remove_unused_condition
Oct 21, 2024
Merged

[Filebeat][udp] - Remove unnecessary multiplication#41211
rdner merged 8 commits intoelastic:mainfrom
vinit-chauhan:remove_unused_condition

Conversation

@vinit-chauhan
Copy link
Contributor

@vinit-chauhan vinit-chauhan commented Oct 13, 2024

Proposed commit message

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

image

Logs

@vinit-chauhan vinit-chauhan requested a review from a team as a code owner October 13, 2024 21:18
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 13, 2024
@mergify
Copy link
Contributor

mergify bot commented Oct 13, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @vinit-chauhan? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

@mergify
Copy link
Contributor

mergify bot commented Oct 13, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Oct 13, 2024
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Oct 14, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 14, 2024
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 14, 2024

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@pierrehilbert pierrehilbert requested review from rdner and removed request for AndersonQ October 14, 2024 07:07
@pierrehilbert
Copy link
Contributor

pierrehilbert commented Oct 14, 2024

/test

@rdner
Copy link
Member

rdner commented Oct 14, 2024

/test

@pierrehilbert
Copy link
Contributor

pierrehilbert commented Oct 15, 2024

/test

@pierrehilbert
Copy link
Contributor

pierrehilbert commented Oct 16, 2024

/test

@pierrehilbert
Copy link
Contributor

pierrehilbert commented Oct 17, 2024

/test

@pierrehilbert
Copy link
Contributor

pierrehilbert commented Oct 17, 2024

run docs-build

leehinman
leehinman reviewed Oct 18, 2024
View reviewed changes
rdner
rdner requested changes Oct 19, 2024
View reviewed changes
@vinit-chauhan vinit-chauhan requested a review from rdner October 20, 2024 02:46
@pierrehilbert
Copy link
Contributor

pierrehilbert commented Oct 20, 2024

/test

leehinman
leehinman approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Probably needs a changelog entry in bugfix section.

@vinit-chauhan
Copy link
Contributor Author

vinit-chauhan commented Oct 21, 2024

Hey @leehinman - We are just removing a variable declaration that's it. We are not adding or modifying any features. So should I still add an entry?

If yes, that would go under dev changelog, correct?

rdner
rdner approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@rdner rdner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change is alright without a changelog entry, since there is no change of behavior.

@leehinman
Copy link
Contributor

leehinman commented Oct 21, 2024

Hey @leehinman - We are just removing a variable declaration that's it. We are not adding or modifying any features. So should I still add an entry?

No changelog needed then.

@pierrehilbert
Copy link
Contributor

pierrehilbert commented Oct 21, 2024

run docs-build

@rdner rdner merged commit 7ca9893 into elastic:main Oct 21, 2024
mergify bot pushed a commit that referenced this pull request Oct 21, 2024
@vinit-chauhan @rdner
@kush-elastic @mergify
[Filebeat][udp] - Remove unnecessary multiplication (#41211)
d510298 
Remove unnecessary multiplication

---------

Co-authored-by: Denis <denis.rechkunov@elastic.co>
Co-authored-by: Kush Rana <89848966+kush-elastic@users.noreply.github.com>
(cherry picked from commit 7ca9893)
@mergify mergify bot mentioned this pull request Oct 21, 2024
Merged
6 tasks
pierrehilbert pushed a commit that referenced this pull request Oct 22, 2024
@mergify @vinit-chauhan
[Filebeat][udp] - Remove unnecessary multiplication (#41211) (#41351)
7895d5e 
Remove unnecessary multiplication

---------

Co-authored-by: Denis <denis.rechkunov@elastic.co>
Co-authored-by: Kush Rana <89848966+kush-elastic@users.noreply.github.com>
(cherry picked from commit 7ca9893)

Co-authored-by: Vinit Chauhan <chauhanvinit23@gmail.com>
@khushijain21 khushijain21 mentioned this pull request Jun 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rdner rdner rdner approved these changes

@leehinman leehinman leehinman approved these changes

+1 more reviewer

@kush-elastic kush-elastic kush-elastic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vinit-chauhan vinit-chauhan

Labels

backport-8.x Automated backport to the 8.x branch with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Filebeat] udp input - unneccessary multiplication by KiB

6 participants

@vinit-chauhan @elasticmachine @pierrehilbert @rdner @leehinman @kush-elastic